Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Additional Items for the Cheat Sheet #43036

Closed
wants to merge 1 commit into from

Conversation

rishitbhojak
Copy link

@rishitbhojak rishitbhojak commented Aug 14, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 1, 2021
@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 1, 2021

Will be reviewing soon. Sorry for the delay

@jreback
Copy link
Contributor

jreback commented Mar 6, 2022

@rishitbhojak can you merge master

@rishitbhojak
Copy link
Author

@rishitbhojak can you merge master

Can you please elaborate @jreback sir?

@datapythonista
Copy link
Member

There is some nice stuff in the proposed changes, but in general I'm -1 on this. At least in its current version. I add the proposed changes here, to give context to my comments:

Screenshot at 2022-04-05 00-16-28

The dropping a column part seems quite unreadable. Not sure if pop is the method we want to show in the cheatsheet for dropping a column, but regardless, we don't build the dataframe in any other function, I wouldn't do it here.

For the plots, more than a cheatsheet it looks like a gallery. Which is nice, but not sure if the cheatsheet is the right place for this. For a cheatsheet, it could be convenient to list the kind of plots, and the briefly explain what they do. More similar to the two plotting examples were there. Not just showing plot calls with the results, some times showing the data, some times without it.

Unless this can be improved significantly, present the information in a more consistent way, and showing the most relevant data (kde is probably among the least used functions, and there are lots of examples with it)., I'd rather stay with the current version.

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale and doesn't look likely to move forward in it's current state. If interested in continuing, please merge in main and address the review, and this can be reopened

@mroeschke mroeschke closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants