TST: parametrize the tests checking __module__ #60270
Open
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
simonjayhawkins
requested changes
Nov 9, 2024
There was a problem hiding this comment.
Thanks @espoirMur
I hold off merging this for now to avoid conflicts with the other open PRs
jorisvandenbossche
changed the title
|
Thanks @espoirMur for working on this. Now that I've had a closer look at the api testing, I see that the tests are class based and not using fixtures so parameterizing the tests probably would not be beneficial as we won't be able to re-use fixtures to ensure that all of the public api is covered. I suspect that we would need to add the checking of the @jorisvandenbossche what's you thoughts here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrize the test part of #55178