-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: set __module__ on isna and notna #60271
Conversation
pandas/pandas/core/dtypes/missing.py Line 316 in 217a0ed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SiemBerhane
Glad it finally works. Thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Because of merging some of the related PRs, there is now a merge conflict in the tests file. Could you merge the latest main
to resolve that conflict? (and let us know if you need any help with that)
now the documentation for isnull is the same as isna (because it's just an alias to isna). should the docs additionally mention that is an alias? are in IPython the repr now for pd.isnull is would we also want an assert in the tests for pd.isnull and pd.notnull too? |
I think for those aliases it is fine that the repr points to the isna/notna instead (I mean, I wouldn't do specific effort to fix that, although addressing the docstring might also address this). Ideally those docstrings of isnull/notnull should mention they are aliases, though |
__module__
on top-level public objects #55178 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.