Skip to content

TST: Remove match= in test_setitem_invalid to avoid PytestWarning #61577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iabhi4
Copy link
Contributor

@iabhi4 iabhi4 commented Jun 5, 2025

test only change - This PR removes the use of match="" in test_setitem_invalid within base/setitem.py.

Using an empty string as a match pattern triggers a PytestWarning in newer versions of pytest, so the match argument has been removed since the message was not being validated

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jun 6, 2025
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Jun 8, 2025
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd just remove the match parameter (unless we have a check to make sure it exists).

But either way this looks good, thanks for taking care of it @iabhi4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: regex match in compliance tests no longer match pytest expected inputs
4 participants