TST[string]: update expecteds for using_string_dtype to fix xfails #61727
+77
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't 100% obvious that the new repr for Categoricals is an improvement, but it's non-crazy. One of the remaining xfails one is for
eval(repr(categorical_index))
round-tripping that won't be fixable unless we revert back to the old repr behavior.I'm pretty sure that the fix in test_astype_dt64_to_string is correct and the test is just wrong, but merits a close look.
That leaves 12 xfails, including the one un-fixable round-trip one that we'll just remove. Of those...
nan
instead ofNaN
. Not a huge deal but having mixed-and-matched nans/NaNs in the repr is weird.(Update: looks like I missed one in test_http_headers and another in test_fsspec)