TST: Test coverage for Excel Formatter.py #61741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
mroeschke
reviewed
Jun 30, 2025
Comment on lines
+488
to
+492
| breaking_row_count = 2**20 + 1 | ||
| breaking_col_count = 2**14 + 1 | ||
|
|
||
| # Test for too many rows | ||
| row_df = DataFrame(np.zeros(shape=(breaking_row_count, 1))) |
There was a problem hiding this comment.
This there a way to test this without actually allocating such a large array
There was a problem hiding this comment.
Otherwise, I'd prefer not to include this test this case due to the large memory allocation
mroeschke
requested changes
Jun 30, 2025
| df = DataFrame({"A": [1, 2], "B": [3, 4]}) | ||
| msg = "Not all names specified in 'columns' are found" | ||
| with pytest.raises(KeyError, match=msg): | ||
| ExcelFormatter(df, cols=columns) |
There was a problem hiding this comment.
Generally, could you write tests that exercise to_excel instead of ExcelFormatter and its private methods instead?
There was a problem hiding this comment.
That makes a lot of sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Tests added and passed if fixing a bug or adding a new feature
✅ All code checks passed.
Added tests to the ExcelFormatter class, which gets the file up to 93% test coverage in total. The only exception is the
.writefunction, (otherwise writing to excel in the first place is not tested) but is already most definitely covered, but should be tested further.Leo