BUG: .describe() doesn't work for EAs #61707 #61760
Open
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_describe_multiple_dtypes(self): | ||
| """ | ||
| GH61707: describe() doesn't work on EAs which generate | ||
| statistics with multiple dtypes. |
There was a problem hiding this comment.
nitpick can this be a comment instead of a docstring
| @@ -215,6 +216,14 @@ def reorder_columns(ldesc: Sequence[Series]) -> list[Hashable]: | |||
| return names | |||
|
|
|||
|
|
|||
| def has_multiple_internal_dtypes(d: list[Any]) -> bool: | |||
There was a problem hiding this comment.
i think this can be inlined since it is only used once
| @@ -251,6 +260,10 @@ def describe_numeric_1d(series: Series, percentiles: Sequence[float]) -> Series: | |||
| import pyarrow as pa | |||
|
|
|||
| dtype = ArrowDtype(pa.float64()) | |||
| elif has_multiple_internal_dtypes(d): | |||
| # GH61707: describe() doesn't work on EAs | |||
| # with multiple internal dtypes, so return object dtype | |||
There was a problem hiding this comment.
is the relevant characteristic "multiple internal dtypes" or "entries that cant be cast to Float64"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where Series.describe() fails on certain
ExtensionArraydtypes such aspint[kg], due to attempting to cast the result toFloat64Dtype. This is because some of the produced statistics are not castable to float, which raises errors like DimensionalityError.We now avoid forcing a Float64Dtype return dtype when the EA’s scalar values cannot be safely cast. Instead:
If the EA produces outputs with mixed dtypes, the result is returned with
dtype=None.