BUG: Fix TypeError in assert_index_equal when comparing CategoricalIndex with check_categorical=True and exact=False #61941
Conversation
…dex with check_categorical=True and exact=False
|
Hi @mroeschke I'd really appreciate it if you could take a look and provide feedback . Thanks! |
mroeschke
added
the
Testing
Aniketsy
force-pushed
the
bugfix-assert-categoricalindex-typeerror
branch
from
333eb89 to
5edf8ce
Compare
|
Hi @mroeschke, Thank you for your review. I’ve updated the PR based on your feedback ,please have a look when convenient. Additionally, I noticed one check failure (pre-commit.ci-pr) and wanted to ask if you could help clarify the reason behind it. Apologies if this isn't the appropriate way to raise this, please do let me know the correct approach if needed. Thanks again! |
Aniketsy
force-pushed
the
bugfix-assert-categoricalindex-typeerror
branch
from
de5b16b to
08739f2
Compare
Hi @jorisvandenbossche, I ran pre-commit locally and all hooks passed. However, the GitHub checks are still showing a failure. Could you please advise if I’ve missed something? |
|
Hi @mroeschke Thank you! |
| ci1 = CategoricalIndex(["a", "b", "c"], categories=["a", "b", "c"], ordered=False) | ||
| ci2 = CategoricalIndex(["a", "x", "c"], categories=["a", "b", "c"], ordered=False) |
There was a problem hiding this comment.
Can you test when 1 index is CategoricalIndex and the other is just an Index?
There was a problem hiding this comment.
Sorry I had meant an additional test in addition to the one you had
There was a problem hiding this comment.
Please , let me know if , I need to add an additional test .
pandas/_testing/asserters.py
Outdated
| if hasattr(left, "_internal_get_values") and hasattr( | ||
| right, "_internal_get_values" |
There was a problem hiding this comment.
Can you use isinstance checks to call _internal_get_values if the object is a CategoricalIndex?
There was a problem hiding this comment.
Thankyou ! for correcting me . I have updated that
There was a problem hiding this comment.
There is one check fail due to:
CategoricalIndex does not have an _internal_get_values() method.
So should i use .value or something else . Please suggest
#61935
Fixes a bug where
assert_index_equalraises aTypeErrorinstead ofAssertionErrorwhen comparing twoCategoricalIndexobjects withcheck_categorical=Trueandexact=False.Ensures consistency with expected testing behavior by properly raising an
AssertionErrorin these cases.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.