fix: remove malformed workflow and fix hooks.json regex escaping#13
Merged
fix: remove malformed workflow and fix hooks.json regex escaping#13
Conversation
Author
|
@pangerlkr Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks! |
Co-authored-by: pangerlkr <73515951+pangerlkr@users.noreply.github.com>
Claude
AI
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes two CI/workflow validation failures by removing an invalid GitHub Actions workflow file and correcting regex escaping inside an inline node -e hook command.
Changes:
- Removed malformed
.github/workflows/copilot-setup-steps.ymlthat lacked required workflow keys and caused workflow parse/validation errors. - Fixed path-separator character class escaping in
hooks/hooks.jsoninline JS so the regex compiles correctly after JSON + validator unescaping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
hooks/hooks.json |
Adjusts backslash escaping in inline JS regexes to avoid invalid regex syntax during hooks validation. |
.github/workflows/copilot-setup-steps.yml |
Removes a non-workflow YAML file from the workflows directory to prevent GitHub Actions parse/validation failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow failures: a malformed workflow file causing parse errors and invalid regex in hooks validation.
Changes
Removed
.github/workflows/copilot-setup-steps.yml: File contained only GitHub Copilot action parameters without workflow structure (missingname,on,jobs). Appears to be accidentally committed boilerplate.Fixed regex escaping in
hooks/hooks.json:40: Character class pattern for path separators had incorrect escape sequence. Changed[\\/\\\\]→[/\\\\\\\\]to properly match/or\after JSON and JavaScript string unescaping.The regex issue manifested as:
All validation scripts (agents, hooks, commands, skills, rules) now pass.