Skip to content

Fix Windows CI: skip bash-path-incompatible test on win32 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pangerlkr merged 2 commits into from
Mar 12, 2026
+4 −0
Merged

Fix Windows CI: skip bash-path-incompatible test on win32 #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c72624
Initial plan
Copilot Mar 12, 2026
27b537d
fix: skip detect-project bash test on Windows (path backslash incompa…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/hooks/hooks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,6 +2150,10 @@ async function runTests() {

if (
await asyncTest('detect-project writes project metadata to the registry and project directory', async () => {
if (process.platform === 'win32') {
console.log(' (skipped — bash script paths are not Windows-compatible)');
return true;
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip guard returns true, but asyncTest() ignores the callback’s return value (it only awaits it). For consistency with other skips in this file (which just return;) and to avoid implying the return value is meaningful, consider using return; here as well.

Suggested change
return true;
return;

Copilot uses AI. Check for mistakes.
}
const testRoot = createTestDir();
const homeDir = path.join(testRoot, 'home');
const repoDir = path.join(testRoot, 'repo');
Expand Down
Loading