Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASK-928 tuning Zendesk.UserRoleChanged #1421

Merged
merged 3 commits into from
Nov 12, 2024
Merged

ASK-928 tuning Zendesk.UserRoleChanged #1421

merged 3 commits into from
Nov 12, 2024
+22 −1

Conversation

akozlovets098
Copy link
Contributor

Background

False positives for the rule which checks if a user role was changed

Changes

  • Added check for role change in role description

Testing

pat test

@akozlovets098 akozlovets098 requested a review from a team as a code owner November 7, 2024 16:32
@ben-githubs ben-githubs enabled auto-merge (squash) November 12, 2024 15:31
@arielkr256 arielkr256 added rules Real-time log data detections tuning detection tuning labels Nov 12, 2024
@ben-githubs ben-githubs merged commit 4a79a46 into develop Nov 12, 2024
8 checks passed
@ben-githubs ben-githubs deleted the ASK-928-tuning-Zendesk.UserRoleChanged branch November 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 approved these changes

@ben-githubs ben-githubs ben-githubs approved these changes

Assignees
No one assigned
Labels
rules Real-time log data detections tuning detection tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akozlovets098 @ben-githubs @arielkr256