Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A banner stating that v1 is unmaintained, and linking to v2 docs. #12

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Nov 29, 2022

The only manual edit was to the .css file.

The html files were edited via sed:

$ find . -type f -name "*.html" | xargs -n1 sed -i '' -n '1h;1!H;${g;s/<a class="navbar-brand" href="index.html">\n          Pants/<a class="navbar-brand" href="index.html">\n          Pants v1/;p;}' 

$ find . -type f -name "*.html" | xargs -n1 sed -i '' -n '1h;1!H;${g;s/  <\/nav>/    <div class="deprecated">Pants v1 is no longer maintained. See <a href="https:\/\/www.pantsbuild.org\/">here<\/a> for the Pants v2 documentation.<\/div>\n  <\/nav>/;p;}'

@benjyw
Copy link
Contributor Author

benjyw commented Nov 29, 2022

Renders as:
Screen Shot 2022-11-28 at 11 24 20 PM

@benjyw
Copy link
Contributor Author

benjyw commented Nov 29, 2022

I manually tested the rendered docs and they look fine.

Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Benjy.

@benjyw benjyw merged commit da35b29 into pantsbuild:master Nov 30, 2022
@benjyw benjyw deleted the deprecation_banner branch November 30, 2022 00:06
@benjyw
Copy link
Contributor Author

benjyw commented Dec 2, 2022

This is live now: https://v1.pantsbuild.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants