first_tutorial.txt: targets no longer end in BUILD #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes targets of the form: path/dir/BUILD:target which cause errors: ValueError: Spec tests/java/com/pants/examples/hello/greet/BUILD:greet has BUILD as the last path part and BUILD is reserved files
|
Thank you for catching this! Alas, fixing it here won't work; this material is generated from elsewhere. The source is hiding in another repo: https://github.com/pantsbuild/pants/blob/master/src/python/pants/docs/first_tutorial.rst Also, be aware that instead of pull requests, we use rbcommons.com, an instance of reviewboard out on the internet; see http://pantsbuild.github.io/howto_contribute.html |
|
What up Evan! |
|
I'll resubmit this to the correct repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes targets of the form: path/dir/BUILD:target which cause errors:
ValueError: Spec tests/java/com/pants/examples/hello/greet/BUILD:greet
has BUILD as the last path part and BUILD is reserved files