Apply patch to stop memory leak#1
Open
thomasdeanwhite-papermill wants to merge 2 commits intomasterfrom
Open
Conversation
thomasdeanwhite-papermill
changed the title
thomasdeanwhite-papermill
force-pushed
the
memory_patch
branch
2 times, most recently
from
6543b45 to
a3c8592
Compare
thomasdeanwhite-papermill
force-pushed
the
memory_patch
branch
from
a3c8592 to
47bc294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: the YDoc from YJS isn't being destroyed after
getDocis called, meaning they build up in RAM. Awareness also appears to not be destroyed.This PR applies the memory patch found in issue here yjs#24 and fork of Yjs here: yjs@a237b39 (it's actually open as a PR to y-redis repo: yjs#36).
Results from the experiment can be found here: https://whimsical.com/experiment-results-VE9S9puaYBHPw5oT7tokp7
Sadly there's no payload that can go here, I'm happy to run through the experiments and how you can run them if needed.