Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tried fixes for #14774 #14776

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tried fixes for #14774 #14776

wants to merge 3 commits into from
+16 −3

Conversation

Soubhik-10
Copy link
Contributor

No description provided.

@Soubhik-10
Copy link
Contributor Author

@mattsse please check this

@Soubhik-10
Copy link
Contributor Author

@mattsse should I change the original on_invalid_block and take the invalid_header_cache as input for checking?

@mattsse
Copy link
Collaborator

mattsse commented Mar 1, 2025

should I change the original on_invalid_block and take the invalid_header_cache as input for checking

this is not necessary if you define the function in the engine type

@Soubhik-10
Copy link
Contributor Author

@mattsse is this correct ?

mattsse
mattsse reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is correct yes

we have a few more calls to self.invalid_block_hook, so we need to update those as well

@Soubhik-10
Copy link
Contributor Author

@mattsse i have made the changes...please look into it..

@Soubhik-10
Copy link
Contributor Author

Soubhik-10 commented Mar 7, 2025 •
edited
Loading

@mattsse what about this?? For Issue #14774

@Soubhik-10 Soubhik-10 requested a review from mattsse March 7, 2025 17:57
@emhane emhane added the A-engine Related to the engine implementation label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-engine Related to the engine implementation
Projects
Reth Tracker
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soubhik-10 @mattsse @emhane