Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trie): simplify hashed post state partitioning #14892

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore(trie): simplify hashed post state partitioning #14892

wants to merge 8 commits into from
+12 −12

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Mar 7, 2025 •
edited
Loading

Blocked by #14874

There's no need to do this anymore, because accounts now can have their storage root updated without an entry in accounts.

@shekhirin shekhirin added C-debt A clean up/refactor of existing code A-trie Related to Merkle Patricia Trie implementation labels Mar 7, 2025
@shekhirin shekhirin marked this pull request as draft March 7, 2025 11:51
@shekhirin shekhirin marked this pull request as ready for review March 7, 2025 11:53
rkrasiuk
rkrasiuk approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@shekhirin
Copy link
Collaborator Author

Testing

@shekhirin
Copy link
Collaborator Author

Doesn't work, fails with state root mismatches. Turning into a draft while investigating.

@shekhirin shekhirin marked this pull request as draft March 7, 2025 12:57
@shekhirin shekhirin force-pushed the alexey/hashed-state-partition-fix branch from dacac19 to 7ab5d37 Compare March 7, 2025 14:50
mattsse
mattsse reviewed Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only q re info! target

@shekhirin shekhirin marked this pull request as ready for review March 7, 2025 15:59
@shekhirin shekhirin requested a review from fgimenez as a code owner March 7, 2025 15:59
@shekhirin
Copy link
Collaborator Author

Ok, works now

@shekhirin shekhirin requested a review from rkrasiuk March 7, 2025 17:11
@emhane emhane requested a review from mattsse March 12, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt A clean up/refactor of existing code
Projects
Reth Tracker
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @mattsse @rkrasiuk