Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move rpc block conversion to TransactionCompat trait #14918

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yohkaz
Copy link
Contributor

@yohkaz yohkaz commented Mar 8, 2025

WIP, towards #14863


compilation failing at:

   Compiling reth v1.2.2 (/home/yohkaz/projects/reth/bin/reth)
error[E0275]: overflow evaluating the requirement `EthStorage: ChainStorage<EthPrimitives>`
  |
  = note: required for `NodeTypesWithDBAdapter<EthereumNode, Arc<reth_db::implementation::mdbx::DatabaseEnv>>` to implement `NodeTypesForProvider`
  = note: required for `NodeTypesWithDBAdapter<EthereumNode, Arc<reth_db::implementation::mdbx::DatabaseEnv>>` to implement `ProviderNodeTypes`
  = note: required for `BlockchainProvider<NodeTypesWithDBAdapter<EthereumNode, Arc<reth_db::implementation::mdbx::DatabaseEnv>>>` to implement `StateProviderFactory`
  = note: required for `EthTransactionValidator<BlockchainProvider<NodeTypesWithDBAdapter<EthereumNode, Arc<reth_db::implementation::mdbx::DatabaseEnv>>>, EthPooledTransaction>` to implement `TransactionValidator`
  = note: required for `Pool<TransactionValidationTaskExecutor<EthTransactionValidator<BlockchainProvider<...>, ...>>, ..., ...>` to implement `TransactionPool`
  = note: required for `EthTxBuilder` to implement `TransactionCompat<EthPrimitives>`
  = note: the full name for the type has been written to '/home/yohkaz/projects/reth/target/debug/deps/reth-f66433e8bfa116b6.long-type-13505355246900291464.txt'
  = note: consider using `--verbose` to print the full type name to the console

For more information about this error, try `rustc --explain E0275`.
error: could not compile `reth` (bin "reth") due to 1 previous error

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry I didn't expect that this will result in these issues -.-

let me figure out how we can proceed here, there's def something I wanted to tackle for a while which looks like is the blocker here.

will likely open a few issues first to make this actually possible

@yohkaz
Copy link
Contributor Author

yohkaz commented Mar 8, 2025

sure np! I might have missed something or do a wrong change causing this issue. wanted to get your feedback before investing more time : )

@emhane emhane added the A-rpc Related to the RPC implementation label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants