-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: introdue reth era export #15909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, this looks pretty good!
I think we should considering merging both import and export into one crate and rename era-import @RomanHodulak
and I believe we're missing tx.commit calls in import
@RomanHodulak
we could also handle those externally but maybe a better idea to commit file after file?
I think merging and renaming the crates fits. Commit per ERA file seems best for this use-case, i.e. the file remains imported even if the process is interupted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, only thing missing really is a rebase and moving a few things around
CodSpeed Performance ReportMerging #15909 will degrade performances by 10.84%Comparing Summary
Benchmarks breakdown
|
@mattsse I see some era1 in the code, I didn’t see era. I might just be missing it, or this is intended to be era1. To be cautious and mention it here:
|
Hello @yorickdowne :) Will let @mattsse complete but from what I understood : This pr is addressing this feature #15495 that is part of this more global Until now only I guess also we use |
Sorry wont have time to continue. |
Closes #15495.
Only start introducing the functional logic (not the interface with the cli) :
For a certain number of block set up in the config, it fetches the data (header, block body, receipts) to reconstruct the block history and write them directly into era files.
Still to do :