-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: add --http.rpcprefix and --ws.rpcprefix like in geth #19780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #19780 will degrade performances by 28.31%Comparing Summary
Benchmarks breakdown
|
@mattsse It's weird. this pr should has no influence on this bench mark named remove_leaf. |
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
I'm not sure we need actually need this because I think by default this will behave exactly the same as with this layer, e.g.
cast rpc web3_clientVersion -r http://localhost:8545/prefix/
"reth/v1.9.2-7fdd9c3/aarch64-apple-darwin"
start with and then send rpc with out prefix. you will get 404. that's way expect to act like. result in: |
|
hmm, unsure we need this really, let me think about it |
No description provided.