Skip to content

Conversation

@cuiweixie
Copy link
Contributor

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 15, 2025

CodSpeed Performance Report

Merging #19780 will degrade performances by 28.31%

Comparing cuiweixie:rpcprefix (45ac6a6) with main (fce0825)

Summary

❌ 1 regression
✅ 80 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
remove_leaf[1000] 193.4 µs 269.8 µs -28.31%

@cuiweixie
Copy link
Contributor Author

CodSpeed Performance Report

Merging #19780 will degrade performances by 31.33%

Comparing cuiweixie:rpcprefix (b8af23f) with main (fce0825)

Summary

❌ 1 regression ✅ 80 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
remove_leaf[1000] 193.4 µs 281.6 µs -31.33%

@mattsse It's weird. this pr should has no influence on this bench mark named remove_leaf.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

I'm not sure we need actually need this because I think by default this will behave exactly the same as with this layer, e.g.

cast rpc web3_clientVersion -r http://localhost:8545/prefix/
"reth/v1.9.2-7fdd9c3/aarch64-apple-darwin"

@cuiweixie
Copy link
Contributor Author

cuiweixie commented Nov 15, 2025

thanks!

I'm not sure we need actually need this because I think by default this will behave exactly the same as with this layer, e.g.

cast rpc web3_clientVersion -r http://localhost:8545/prefix/
"reth/v1.9.2-7fdd9c3/aarch64-apple-darwin"

start with

./target/debug/reth node --dev  --http --http.rpcprefix=/prefix  --http.api=web3,debug,eth,txpool,net --dev.block-time=1s

and then send rpc with out prefix. you will get 404. that's way expect to act like.

cast bn --rpc-url http://127.0.0.1:8545/

result in:

Error: HTTP error 404 with empty body

@mattsse
Copy link
Collaborator

mattsse commented Nov 17, 2025

hmm, unsure we need this really, let me think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants