Skip to content

Conversation

@Fallengirl
Copy link
Contributor

Some imports in test_utils/mod.rs were unconditionally imported but only used when the "file-client" feature is enabled or during testing. This adds proper cfg gates to ensure they're only compiled when actually needed.

Changes:

  1. Added cfg attributes for feature-gated imports (futures, tokio, std::io)
  2. Added explicit tempfile crate usage to satisfy unused_crate_dependencies lint
  3. Added alloy-rlp and itertools to dev-dependencies for test compilation

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will allow if we can move the feature gated imports into the functions that require them

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Nov 20, 2025
@Fallengirl
Copy link
Contributor Author

moved into the function, thanks

@Fallengirl Fallengirl requested a review from mattsse November 25, 2025 18:46
@Fallengirl
Copy link
Contributor Author

@mattsse pinging

@mattsse mattsse changed the title fix: clean up unused imports and dependencies in reth-downloaders chore(deps): clean up unused imports and dependencies in reth-downloaders Dec 6, 2025
@mattsse mattsse added this pull request to the merge queue Dec 6, 2025
Merged via the queue into paradigmxyz:main with commit d765521 Dec 6, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants