Skip to content

Fix Windows build compatibility #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

mematthias
Copy link
Contributor

This pull request is a small excerpt from the #289 PR.

Summary

This pull request restores the ability to build the crate on Windows.

Build successfully on:

  • Windows 11
  • Rust 1.77.0 (stable)
  • Rust 1.87.0 (stable)

@wiktor-k
Copy link
Collaborator

I hope you don't mind but I've pushed the single "build on windows" commit from my PR #276. Let's see if it goes through (as it breaks when applied to main).

Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Thanks! 👍

Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@hug-dev hug-dev merged commit ef5aec2 into parallaxsecond:main Jun 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants