Skip to content

Fixed benchmark problems 10, 11, 48 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fixed benchmark problems 10, 11, 48 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion drivers/cpp/benchmarks/geometry/10_geometry_convex_hull/baseline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ void NO_INLINE correctConvexHull(std::vector<Point> const& points, std::vector<P
std::vector<Point> lowerHull;
upperHull.push_back(pointsSorted[0]);
upperHull.push_back(pointsSorted[1]);
lowerHull.push_back(pointsSorted[pointsSorted.size() - 1]);
lowerHull.push_back(pointsSorted[pointsSorted.size() - 2]);

for (size_t i = 2; i < pointsSorted.size(); i++) {
while (upperHull.size() > 1
Expand All @@ -47,7 +49,7 @@ void NO_INLINE correctConvexHull(std::vector<Point> const& points, std::vector<P
}
lowerHull.push_back(pointsSorted[pointsSorted.size() - i - 1]);
}
upperHull.insert(upperHull.end(), lowerHull.begin(), lowerHull.end());
upperHull.insert(upperHull.end(), lowerHull.begin()+1, lowerHull.end()-1);

hull = upperHull;
return;
Expand Down
4 changes: 3 additions & 1 deletion drivers/cpp/benchmarks/geometry/11_geometry_convex_hull_perimeter/baseline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ double NO_INLINE correctConvexHullPerimeter(std::vector<Point> const& points) {
std::vector<Point> lowerHull;
upperHull.push_back(pointsSorted[0]);
upperHull.push_back(pointsSorted[1]);
lowerHull.push_back(pointsSorted[pointsSorted.size() - 1]);
lowerHull.push_back(pointsSorted[pointsSorted.size() - 2]);

for (size_t i = 2; i < pointsSorted.size(); i++) {
while (upperHull.size() > 1
Expand All @@ -52,7 +54,7 @@ double NO_INLINE correctConvexHullPerimeter(std::vector<Point> const& points) {
}
lowerHull.push_back(pointsSorted[pointsSorted.size() - i - 1]);
}
upperHull.insert(upperHull.end(), lowerHull.begin(), lowerHull.end());
upperHull.insert(upperHull.end(), lowerHull.begin()+1, lowerHull.end()-1);

double perimeter = 0;
for (size_t i = 0; i < upperHull.size() - 1; i++) {
Expand Down
1 change: 0 additions & 1 deletion drivers/cpp/benchmarks/sparse_la/48_sparse_la_sparse_axpy/cpu.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ bool validate(Context *ctx) {
correctSparseAxpy(alpha, x, y, correct);

// compute test result
test.clear();
sparseAxpy(alpha, x, y, test);
SYNC();

Expand Down