Igor auto bump #31
Draft
Igor auto bump #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 4ec98b3 Author: Benjamin Kampmann <[email protected]> Date: Tue Oct 27 17:45:46 2020 +0100 resolve git, better erroring commit a17b9fc Author: Benjamin Kampmann <[email protected]> Date: Tue Oct 27 13:08:31 2020 +0100 calculating the graph commit 5c18fd1 Merge: 9009841 9cbfd17 Author: Benjamin Kampmann <[email protected]> Date: Tue Oct 27 12:08:46 2020 +0100 Merge remote-tracking branch 'origin/master' into ben-auto-bump commit 9009841 Merge: ce42cac a9bed52 Author: Benjamin Kampmann <[email protected]> Date: Tue Oct 27 09:18:56 2020 +0100 Merge branch 'ben-update-to-latest-cargo' into ben-auto-bump commit ce42cac Merge: 23b187e f8eeefc Author: Benjamin Kampmann <[email protected]> Date: Tue Oct 27 09:14:14 2020 +0100 Merge remote-tracking branch 'origin/master' into ben-auto-bump commit 23b187e Author: Benjamin Kampmann <[email protected]> Date: Mon Sep 21 11:51:17 2020 +0200 adding current state commit aff288f Author: Benjamin Kampmann <[email protected]> Date: Tue Sep 8 18:29:50 2020 +0200 update to latest dependencies
This brings it in line with what implementation does and should be more in line with what --packages does (i.e. it does not figure out dependents).
This groups package selection logic in one place, reducing the need for boxing the resulting closure and making it easier to reason locally about the package selection.
Previous version was traversing the entire graph for each member, yielding a quadratic time. Moreover, an auxiliary data structure used internally by petgraph panicked while traversing, so we run a simple DFS ourselves to mark all transitive dependents and remove packages that were not marked in the process.
We want to start with packages whose changes can have the most rippling effect across the graph rather than the ones no other package depends on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.