-
-
Notifications
You must be signed in to change notification settings - Fork 69
Setting property to nil causes delete op on save #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // | ||
| // NullableProperty.swift | ||
| // | ||
| // Created by Steven Grosmark on 6/10/20. | ||
| // Source: https://github.com/g-mark/NullCodable | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// Property wrapper that encodes `nil` optional values as a delete operation | ||
| /// when encoded using `JSONEncoder`. | ||
| /// | ||
| /// For example, adding `@NullableProperty` like this: | ||
| /// ```swift | ||
| /// struct Test: Codable { | ||
| /// @NullableProperty var name: String? = nil | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| @propertyWrapper | ||
| public struct NullableProperty<Wrapped> { | ||
|
|
||
| public var wrappedValue: Wrapped? | ||
|
|
||
| public init(wrappedValue: Wrapped?) { | ||
| self.wrappedValue = wrappedValue | ||
| } | ||
| } | ||
|
|
||
| extension NullableProperty: Encodable where Wrapped: Encodable { | ||
|
|
||
| public func encode(to encoder: Encoder) throws { | ||
| var container = encoder.singleValueContainer() | ||
| switch wrappedValue { | ||
| case .some(let value): | ||
| try container.encode(value) | ||
|
|
||
| case .none: | ||
| try container.encode(Delete()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension NullableProperty: Decodable where Wrapped: Decodable { | ||
|
|
||
| public init(from decoder: Decoder) throws { | ||
| let container = try decoder.singleValueContainer() | ||
| if !container.decodeNil() { | ||
| wrappedValue = try container.decode(Wrapped.self) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension NullableProperty: Hashable where Wrapped: Hashable { } | ||
| extension NullableProperty: Equatable where Wrapped: Equatable { } | ||
|
|
||
| extension KeyedDecodingContainer { | ||
|
|
||
| public func decode<Wrapped>(_ type: NullableProperty<Wrapped>.Type, forKey key: KeyedDecodingContainer<K>.Key) | ||
| throws -> NullableProperty<Wrapped> where Wrapped: Decodable { | ||
| return try decodeIfPresent(NullableProperty<Wrapped>.self, forKey: key) ?? | ||
| NullableProperty<Wrapped>(wrappedValue: nil) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For playgrounds this probably only need a couple of examples. You can add a separate page that shows multiple different use-cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I wanted to make sure to cover any potential cases in case the user was only looking a one page of the Playground instead of looking through some of the earlier pages. I can change this to only add the changes to the first section, with maybe a little extra info there. I don't think there are really any other use-cases, if you're going to set a property to nil at some point then you'd need the wrapper.