Skip to content

Add vm-browserify #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add vm-browserify #17

wants to merge 2 commits into from

Conversation

cusspvz
Copy link

@cusspvz cusspvz commented Feb 16, 2019

@parshap
Copy link
Owner

parshap commented Jun 8, 2019

This isn't going to work in a React Native environment because it depends on document.createElement('iframe'): https://github.com/browserify/vm-browserify/blob/6b0773a7a2e2e0d67b9ee7f31102d3e635bf00b1/index.js#L61

I think a mock implementation for vm is more appropriate, where the api is mocked out but there is no implementation.

@cusspvz
Copy link
Author

cusspvz commented Jun 8, 2019

https://github.com/requirehit/native-vm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cusspvz @parshap