Skip to content

feat: replace the hand-written CreateUserArgs, UpdateUserArgs, and PassageUser class aliases with codegen models #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Mar 10, 2025

What's New?

Removes the hand-written class aliases that rename the codegen models and replaces them with new renamed codegen'd models that utilize the new modelNameMapping flag available in v7.12.0 (#108)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Base automatically changed from PSG-6012-update-codegen-version to main March 10, 2025 19:42
@ctran88 ctran88 force-pushed the PSG-6012-codegen-with-model-name-mapping branch from 14ed6d4 to 32c4829 Compare March 10, 2025 19:43
@ctran88 ctran88 force-pushed the PSG-6012-codegen-with-model-name-mapping branch from 3d1e47a to f03351a Compare March 10, 2025 21:15
@ctran88
Copy link
Contributor Author

ctran88 commented Mar 10, 2025

due to the namespace differences with the handwritten aliases and the codegen code, and the amount of code modding it would take to make it backwards compatible, codegen with the model renaming isn't worth it at this point. we should pick it back up when we're preparing the next major release

@ctran88 ctran88 closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant