[WIP] Improve Code Quality #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iamcarbon
commented
Aug 21, 2023
•
iamcarbon
commented
- Remove platform specific logic that is no longer necessary on .NET core
- Add implicit casting to CborByteString and CborTextString to their respective types (byte[] and string)
- Use optimized OperatingSystem classes for platform specific logic
- Minor test cleanup
- Improve AndroidKey error messages
- Improve CredentialPublicKey test coverage
.NET core populates Oid on named curves for Windows and Linux
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 75.13% 75.56% +0.43%
==========================================
Files 100 100
Lines 2783 2779 -4
Branches 460 455 -5
==========================================
+ Hits 2091 2100 +9
+ Misses 576 560 -16
- Partials 116 119 +3
|
|
@abergs Ready for review |
iamcarbon
commented
Aug 21, 2023
iamcarbon
commented
Aug 21, 2023
iamcarbon
commented
Aug 21, 2023
abergs
reviewed
Aug 23, 2023
|
@iamcarbon I understood your making some small changes? I'm OK either way. |
|
@abergs All set. I know these small changes can get tedious to review -- and I appreciate you for for taking the time and for the feedback. The 4.0 release is shaping up nicely! |
iamcarbon
commented
Aug 23, 2023
abergs
approved these changes
Aug 23, 2023
|
@iamcarbon Your contributions are highly valued! |
^ Extremely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.