fix: handle cancelled menu without crashing #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pressing Ctrl+C in a menu, the render_menu function would crash with IndexError because element.selected was invalid after cancellation. Now we check if the element was cancelled or has an invalid selection before trying to access the selected option, and display 'Cancelled.' instead.
|
Hi, thanks for contributing to this project! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of ---
release type: patch
---
Description of the changes, ideally with some examples, if adding a new feature.
Release type can be one of patch, minor or major. We use [semver](https://semver.org/), so make sure to pick the appropriate type. If in doubt feel free to ask :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing Ctrl+C in a menu, the
render_menufunction would crash withIndexErrorbecauseelement.selectedwas invalid after cancellation.Problem
This happened in
render_menuat:Solution
Check if the element was cancelled or has an invalid selection before trying to access the selected option. Display "Cancelled." with the cancelled style instead of crashing.