This repository was archived by the owner on Jun 7, 2026. It is now read-only.
refactor(test): replace setTimeout with deterministic spawn polling - #63
Merged
Merged
Conversation
Move the deterministic spawn polling helper from health.test.ts to the shared helpers.ts file so it can be reused across all test files. Part of #29
Replace setTimeout patterns with deterministic spawn polling to eliminate flaky test timing issues. Part of #29
Replace setTimeout patterns with deterministic spawn polling to eliminate flaky test timing issues. Part of #29
Replace setTimeout patterns with deterministic spawn polling to eliminate flaky test timing issues. Part of #29
Replace setTimeout patterns with deterministic spawn polling to eliminate flaky test timing issues. Combined staggered streaming timeouts into a single afterSpawnCalled callback. Part of #29
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterSpawnCalledhelper fromhealth.test.tsto sharedhelpers.tssetTimeoutpatterns with deterministic spawn polling across test filesChanges
helpers.tsafterSpawnCalledhelper functionhealth.test.tsstream.test.tsgenerate.test.tsapp.test.tssdk.integration.test.tsHow it works
The
afterSpawnCalledhelper polls every 1ms untilmockSpawnhas been called, then executes the callback. This eliminates race conditions wheresetTimeout(50)might fire before or after the actual spawn call depending on CI load.Closes #29
Test plan