This repository was archived by the owner on Jun 7, 2026. It is now read-only.
test: improve stream-object test coverage across packages - #79
Merged
Conversation
Add tests for uncovered code paths in stream-object.ts: - null/non-object parsed values (skip handling) - sessionId resolution from result event (fallback) - sessionId rejection on error before session event - SSE parse errors (critical and non-critical) - NO_SESSION and NO_USAGE flush handlers Add test for streamObject via client interface to reach 100% coverage on client.ts. Coverage improvements: - stream-object.ts: 80% → 99.56% - client.ts: 93.75% → 100% Closes part of #74
Add tests for uncovered code paths in stream_object.py: - sessionId resolution from result event when no session event - sessionId rejection on error before session event - SSE_PARSE_ERROR for critical events with malformed JSON - Non-critical parse errors (partial-object) continue streaming - NO_SESSION when stream ends without session or result events Coverage improvement: - stream_object.py: 75% → 84% Closes part of #74
Add tests for uncovered code paths in stream-object.ts: - Warning events for markdown-block extraction fallback - Warning events for object-extraction fallback - Warning events for array-extraction fallback - Buffer warning on clean exit with unparseable data - Interrupt exit code with buffer data (no warning) - Parse error on final object in close handler Coverage improvement: - stream-object.ts: 67.98% → 78.94% Closes part of #74
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage Improvements
stream-object.tsstream-object.tsclient.tsstream_object.pyChanges by Package
TypeScript SDK
Python SDK
Gateway
Test plan
bun run test)uv run pytest)Closes #74