Conversation
…get filtering working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission description
A D&D monster manual. I wanted to use a carousel view to supply a filter, and a carousel view to display the actual monsters.
Android
iOS
I have also used images included in the project rather than links as I wanted to see how it performed.
What went well
Setting up the carousel was fairly straightforward, as well as repopulating after filtering. Android looks as I intended and scrolls well.
What didn't go well
iOS looks terrible and I'm not entirely sure why, but I haven't had a chance to look into it properly. It is (to be quite honest) likely to be something I have done wrong.
I also noticed that some of the text was not showing when swiping, although I could see it in the data extracted from the CSV when I debugged.
The images seemed fine though - I just didn't have images for every monster.
Missing or desired things
Nothing that hasn't been mentioned by other Pull Requests :)