Skip to content

15 places to visit in Portugal#31

Open
DiogoMartinh0 wants to merge 4 commits intopauldipietro:masterfrom
DiogoMartinh0:master
Open

15 places to visit in Portugal#31
DiogoMartinh0 wants to merge 4 commits intopauldipietro:masterfrom
DiogoMartinh0:master

Conversation

@DiogoMartinh0
Copy link

@DiogoMartinh0 DiogoMartinh0 commented Sep 25, 2019

Submission description

My idea was to show-off what great places we have to visit in Portugal. I based my CarouselView from this two websites:
Website 1 - Culture Trip
Website 2 - Lonely Planet

GIF of my sample

What went well

Last time I tried using the CarouselView with a stable version of 4.1 (If I recall correctly), it wasn't that good, I wasn't able to achieve the goal I had at the time. With this one, overall a very smooth experience.

What didn't go well

IsBounceEnabled didn't seem to have any effect upon reaching the end of the carousel

Missing or desired things

I like this PR #7575

I'm missing a property to set how many items I want to be shown on screen. NumberOfSideItems does not achieve this, as if I set it to 1, three items appear on screen. I've consulted the spec and "Number of visible items on each side of the current item , defaults to 0". Ok, understood, but how can I set it to show two items at a time? It seems that with this property we can only achieve odd numbers of items displayed, and never even ones 😛

Anything else

I haven't used the EmptyView in this example but I've tried it before, it's a really cool feature, thanks for that!

I've seen that IsLoopEnabled is not yet implemented, that would be a pretty cool feature to try out, waiting on that! Also waiting on IndicatorsView to be finished. Hopefully we get all that in the first stable 4.3 :)

An insight on XAML Hot Reload, It worked semi-ok, I still had to restart the debugging process a few times since it wasn't picking up what I've changed or just did some random change I didn't ask for 😛
I've noticed that both XAML reloaders that I've used in the past (Andrei Misiukevich's Hot Reload and XAML Hot Reload) are not forgiving when the user writes some invalid XAML code. Please allow us to recover from errors.

Hooray the 🐒s

@pauldipietro
Copy link
Owner

@DiogoMartinh0 Thanks for the contribution. We've had feedback about the desire to show two items from others. Currently, the best solution to this is to use the PeekAreaInsets with a thickness value on one side equivalent to whatever the width of your items are. We're discussing potential alternatives to make this a better experience for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants