Fix metronome with changing meter #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way if the meter changes, but the drum pattern is not redefined, perhaps the implemented one is the specified behavior, so it may not just be a workaround. I'm interested in your opinion. |
presidento
force-pushed
the
metronome
branch
from
7494701 to
2607585
Compare
This is a workaround. Ideally for the following ABC snippet:
M: 3/4
%%MIDI drum ddd 76 77 77 90 90 90
first the meter change is handled, then the drum section.
Unfortunately as I see, the %%MIDI part is handled first,
so when the new drum definition has to be handled, the
meter is the previous one.
With this commit the drumDefinition is recalculated every
time when meter changes, so the updated drum pattern
will be used.
Also it will follow the standards when somebody just
forgot to update the drum pattern, and the meter changes.
presidento
force-pushed
the
metronome
branch
from
2607585 to
b82eb42
Compare
presidento
changed the title
|
I reverted this patch for myself, since #886 (metronome support) do what I need for metronome. But it can be helpful for others. So feel free to merge or close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working PoC of a workaround for #849. The problem is that
%%MIDI drumis always processed beforeM:. I don't know whether it is intentional. If you like this approach, I can clean it up and even add tests.