Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: initial support for collecting telemetry #372

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[feature]: initial support for collecting telemetry #372

wants to merge 22 commits into from

Conversation

robomics
Copy link
Contributor

No description provided.

@robomics robomics added the enhancement New feature or request label Mar 16, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.00758% with 227 lines in your changes missing coverage. Please review.

Project coverage is 76.70%. Comparing base (fe9958c) to head (632e998).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/cli/cli.cpp 22.10% 69 Missing and 5 partials ⚠️
src/hictk/include/hictk/tools/telemetry.hpp 74.10% 55 Missing and 17 partials ⚠️
src/hictk/include/hictk/tools/cli.hpp 9.85% 60 Missing and 4 partials ⚠️
src/hictk/main.cpp 65.51% 6 Missing and 4 partials ⚠️
src/hictk/include/hictk/tools/tools.hpp 0.00% 4 Missing ⚠️
src/hictk/cli/cli_validate.cpp 33.33% 1 Missing and 1 partial ⚠️
src/hictk/fix_mcool/fix_mcool.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   77.14%   76.70%   -0.44%     
==========================================
  Files         177      179       +2     
  Lines       22771    23393     +622     
  Branches     2469     2537      +68     
==========================================
+ Hits        17566    17944     +378     
- Misses       4146     4341     +195     
- Partials     1059     1108      +49
Flag Coverage Δ
[tests fuzzer](https://app.codecov.io/gh/paulsengroup/hictk/pull/372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 28.56% <ø> (-0.07%)
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.40% <57.00%> (-0.19%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 76.40% <ø> (+<0.01%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

robomics added 4 commits March 17, 2025 10:55
@robomics
Workaround weird bug in exception handling
9d4d059 
For some reason some exceptions were not caught (as in they
reached main and caused std::abort() to be called) because of the
if constexpr inside std::visit.
The odd part is that this only occurred when building the Dockerfile
(I was not able to reproduce locally, nor with the regular CI).
@robomics
Fix Dockerfile builds on linux/arm64
42b57d4
@robomics
Address clang-tidy warnings
73ea539
@robomics
Various minor changes
fcc1c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robomics