Skip to content

nix: deny unused lint group in dedicated flake check #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nothingmuch merged 2 commits into from
May 29, 2026
Merged

nix: deny unused lint group in dedicated flake check #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee17363
nix: deny unused lint group in dedicated flake check
nothingmuch May 28, 2026
355c672
nix: trivial readability refactor
nothingmuch May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions nix/checks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,19 @@
mkdir -p $out
'';

unused-lints = toolchains.nightly.mkCargoDerivation (
commonArgs
// {
cargoArtifacts = cargoArtifactsDev;
CARGO_PROFILE = "dev";
pnameSuffix = "-unused-lints";
buildPhaseCargoCommand = ''
RUSTFLAGS="''${RUSTFLAGS:-} -D unused" cargo check --all-targets --all-features
'';
installPhase = "mkdir -p $out";
}
);

no-todo-comments = pkgs.runCommand "no-todo-comments-${rev}" { inherit src; } ''
if grep -rn --exclude-dir=contrib 'TO[D]O\|FIX[M]E' $src/ 2>/dev/null; then
echo "FAIL: unresolved work-item markers found"
Expand All @@ -113,18 +126,19 @@
checks = checks // {
quick = pkgs.symlinkJoin {
name = "quick-checks-${rev}";
paths = [
checks.tests-nightly-dev
checks.clippy
paths = with checks; [
tests-nightly-dev
clippy
];
};
lint = pkgs.symlinkJoin {
name = "lint-checks-${rev}";
paths = [
checks.cargo-sort
checks.clippy
checks.doc
checks.no-todo-comments
paths = with checks; [
cargo-sort
clippy
doc
unused-lints
no-todo-comments
];
};
nightly = pkgs.symlinkJoin {
Expand Down
Loading