Skip to content

nix: cargo-sort improvements#33

Open
nothingmuch wants to merge 1 commit into
mainfrom
cargo-sort-improvements
Open

nix: cargo-sort improvements#33
nothingmuch wants to merge 1 commit into
mainfrom
cargo-sort-improvements

Conversation

@nothingmuch

Copy link
Copy Markdown
Collaborator
  • add to devshell
  • run as part of nix fmt
    • this is done before treefmt
    • taplo preserves key order

see also #27

- add to devshell
- run as part of `nix fmt`
  - this is done before treefmt
  - taplo preserves key order

@arminsabouri arminsabouri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Mshehu5 Mshehu5 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK this is a good addition

@benalleng

Copy link
Copy Markdown

Why is cargo-sort chosen here instead of a rules explicit for Cargo.toml in a taplo.toml?
https://github.com/payjoin/rust-payjoin/blob/master/taplo.toml

@nothingmuch

Copy link
Copy Markdown
Collaborator Author

Why is cargo-sort chosen here instead of a rules explicit for Cargo.toml in a taplo.toml? https://github.com/payjoin/rust-payjoin/blob/master/taplo.toml

laziness (cargo sort understands cargo conventions whereas taplo needs to be configured in order to do the same, and configuring requires making decisions that i would rather delegate to the maintainers of cargo sort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants