ffi: Extract shared InMemory persister helpers#1553
Merged
spacebear21 merged 1 commit intoMay 11, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 25698285159Coverage remained the same at 85.294%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
Author
Contributor
|
Looks good to me. If build and tests pass, I'm good with it. |
Collaborator
Author
|
Tests are failing due to an unrelated dependency issue, I have a fix in #1541 |
spacebear21
force-pushed
the
ffi-extract-shared-in-memory-persisters
branch
2 times, most recently
from
f6028a9 to
ec8f221
Compare
spacebear21
force-pushed
the
ffi-extract-shared-in-memory-persisters
branch
from
ec8f221 to
ecd8a8f
Compare
benalleng
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1529 somewhat (the suggested approach is misguided, per #1533 (comment))
Supersedes #1533
Authored with Codex 5.5
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.