Skip to content

Add C# SDK to nix dev shell #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 1 commit into from
May 19, 2026
Merged

Add C# SDK to nix dev shell #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,11 @@
"payjoin-mailroom-image" = mkContainerImage "payjoin-mailroom" packages.payjoin-mailroom tag;
};

dotnetSdk = pkgs.dotnetCorePackages.combinePackages [
pkgs.dotnetCorePackages.sdk_10_0
pkgs.dotnetCorePackages.runtime_8_0
Comment on lines +274 to +275

@DanGould DanGould May 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this setup makes sense to me concept ACK

@benalleng benalleng May 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an attempt at creating a csharp specific dev shell in #1574 similar to the python dev shell but I received some errors with this sdk/runtime version setup. @chavic do you have some insight on this that I may have missed from the dev check in this week.

@chavic chavic May 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need a follow-up fix

];

devShells = builtins.mapAttrs (
_name: craneLib:
craneLib.devShell {
Expand All @@ -281,6 +286,7 @@
cargo-watch
rust-analyzer
dart
dotnetSdk
cargo-fuzz
bzip2 # needed for some machines to have access to libzip at runtime
codespell
Expand All @@ -290,6 +296,8 @@
];
BITCOIND_EXE = pkgs.lib.getExe' pkgs.bitcoind "bitcoind";
BITCOIND_SKIP_DOWNLOAD = 1;
DOTNET_ROOT = "${dotnetSdk}/share/dotnet";
DOTNET_CLI_TELEMETRY_OPTOUT = "1";
}
) craneLibVersions;

Expand Down
7 changes: 7 additions & 0 deletions payjoin-ffi/csharp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ Welcome to the C# language bindings for the [Payjoin Dev Kit](https://payjoindev

Follow these steps to clone the repository and run the tests.

With nix, the default development shell provides the Rust toolchain, .NET 10 SDK,
and .NET 8 runtime:

```shell
nix develop -c bash payjoin-ffi/csharp/contrib/test.sh
```

```shell
git clone https://github.com/payjoin/rust-payjoin.git
cd rust-payjoin/payjoin-ffi/csharp
Expand Down
2 changes: 1 addition & 1 deletion payjoin-ffi/csharp/global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"version": "10.0.100",
"rollForward": "latestFeature"
}
}
Loading