-
Notifications
You must be signed in to change notification settings - Fork 99
Make Cargo-minimal and Cargo-recent lockfiles follow expected convention #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
79c8bd4
Fix stale lockfile precommit hook
benalleng ea0d243
Update toml resolver
benalleng e74fa5f
Merge lint and lint-ffi into a single CI job
benalleng c94ea23
Ensure lint scripts also are locked to the existing lockfiles
benalleng 5d0a9f7
Add weekly lockfile maintenance job
benalleng 19d702d
Update minimum and recent deps to match expected lockfile convetions
benalleng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Cargo lock maintenance | ||
| on: | ||
| schedule: | ||
| - cron: "0 20 * * 0" # weekly at 20:00 UTC | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| update-lock-files: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: UPDATE_DEPS=true bash contrib/update-lock-files.sh | ||
| - uses: peter-evans/create-pull-request@v7 | ||
| with: | ||
| token: ${{ secrets.GH_TOKEN_FOR_UPDATES }} | ||
| commit-message: "chore: update Cargo lock files" | ||
| title: "chore: update Cargo lock files" | ||
| branch: chore/cargo-lock-update | ||
| add-paths: | | ||
| Cargo-minimal.lock | ||
| Cargo-recent.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this was separated in the first place? Chesterson's fence?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into the history for this very question. I think that we simply didn't want any failures to hit the main crate at the time as there is no other explanation was given to keep them separate. #846 included commits to actually make it pass the lint so I suspect that was partly why as there was perhaps some expectation of continued instability. @arminsabouri do you have a recollection about any additional motivation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the workspaces used to be separated because there was no way to compile
payjoin-ffiwith the old MSRV, so that'd be one potential reason. Now everything is in the top levelCargo.tomlworkspace it can all be compiled and linted together.