Skip to content

Upgrade docker/login-action to v4#1680

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:upgrade-docker-login-action
Jun 24, 2026
Merged

Upgrade docker/login-action to v4#1680
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:upgrade-docker-login-action

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

Description

The docker/login-action@v3 tag still runs on Node.js 20, which GitHub Actions has deprecated. Every run of the release-image workflow emits:

Node 20 is being deprecated. This workflow is running with Node 24 by default.

docker/login-action v4.0.0 switches the default runtime to Node 24, silencing the warning. This follows the same convention already used in the repo for major-version tags (e.g. actions/checkout@v6).

Closes #1679

Disclosure: co-authored by Claude Code

The v3 tag still runs on Node.js 20, which GitHub Actions has
deprecated in favor of Node 24. docker/login-action v4.0.0 switches
the default runtime to Node 24, silencing the deprecation warning
emitted on every run.

Closes payjoin#1679
@spacebear21 spacebear21 requested a review from benalleng June 24, 2026 20:21
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28127015218

Coverage remained the same at 85.405%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15108
Covered Lines: 12903
Line Coverage: 85.41%
Coverage Strength: 361.95 hits per line

💛 - Coveralls

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 50a6fd1

Another no space left on device error in CI though

@spacebear21 spacebear21 merged commit 24df451 into payjoin:master Jun 24, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker/login uses node.js 20

3 participants