Cli auto cancel#1688
Draft
benalleng wants to merge 5 commits into
Draft
Conversation
Removes the completed_at DB column and the "Completed At" history display column. Session status is now derived from the event log via SessionHistory::status(); resume only acts on SessionStatus::Active. SenderPersister and ReceiverPersister close() append a Closed(Aborted) event so expired/failed sessions read as terminal on subsequent replays rather than re-erroring.
Prints the session_id alongside the send/receive 'session established' messages so users can track or cancel sessions. Adds a 'Fallback Tx available' qualifier to aborted sessions in history output when a fallback transaction is present, mirroring the existing success suffix.
Collaborator
Coverage Report for CI Build 28291105946Coverage increased (+0.06%) to 85.577%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1683 And rewires the cli to better handle the change in the db resulting from no longer having
completed_atas well as some pure enhancements like checking expiry mid loop instead of only on startup.Blocked by #1683
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.