Skip to content

payjoin-ffi README fixes#732

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:ffi-readme-fixes
Jun 3, 2025
Merged

payjoin-ffi README fixes#732
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:ffi-readme-fixes

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

Consolidate the test sections and update the repository URL.

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install --requirement requirements.txt --requirement requirements-dev.txt

This is still in here, and is wrong because requirements.txt no longer exists

nvm, was in the wrong directory

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 939f204

followed on local and it appears to work

@spacebear21 spacebear21 merged commit 0741d3f into payjoin:master Jun 3, 2025
13 checks passed
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 15425258167

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.329%

Totals Coverage Status
Change from base Build 15400978156: 0.0%
Covered Lines: 6420
Relevant Lines: 7613

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants