Repository navigation
fix: deep-copy omitted field values from the original document - #19398
Draft
JarrodMFlesch wants to merge 9 commits into
Draft
JarrodMFlesch wants to merge 9 commits into
JarrodMFlesch wants to merge 9 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep-copies omitted field values with
deepCopyObjectSimpleso nested JSON arrays keep their shape and protected nested fields retain their stored values. Adds integration coverage for partial updates and draft saves.Fixes #13853
Fixes #18415
Supersedes: closes #17713, closes #18203, closes #18426.
Related:
3.xand supersedes fix: preserve nested arrays in cloneDataFromOriginalDoc #17492.Issue/Fix videos
Preserve nested JSON arrays
I chose bulk Publish because it sends only { _status: 'published' }, leaving the JSON field out of the request. That triggers the faulty fallback copy and clearly demonstrates that an unrelated update corrupts untouched data.
Before:
pyld-4669-before-take-2.mp4
After:
pyld-4669-after-take-2.mp4