refactor: improve hash retrieval in getMerchantConfig function #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-herman
approved these changes
Sep 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
## [1.73.0](v1.72.0...v1.73.0) (2025-09-30) ### Features * create ITES LT messages and modals ([#1221](#1221)) ([4dc7365](4dc7365)) ### Code Refactoring * improve hash retrieval in getMerchantConfig function ([#1228](#1228)) ([e436a11](e436a11)) * US modal legal disclosure updates ([#1231](#1231)) ([99e9be8](99e9be8))
|
🎉 This PR is included in version 1.73.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The merchant_config= parameter appears in the request URL because getMerchantConfig() is returning an empty string ("") rather than undefined.
Screenshots
Existing issue
Testing instructions
Update getMerchantConfig to
return return hash || undefined;locally. Check that the merchant_config is not being sent