error handling w/o error slices and more

.github/dependabot.yaml

@@ -0,0 +1,15 @@
+version: 2
+updates:
+- package-ecosystem: gomod
+  directory: /
+  schedule:
+    interval: weekly
+  reviewers:
+    - "daveshanley"
+
+- package-ecosystem: github-actions
+  directory: /
+  schedule:
+    interval: monthly
+  reviewers:
+    - "daveshanley"

.github/workflows/build.yaml

@@ -1,49 +1,84 @@
-name: Build
+name: Build & Test
 
 on:
   push:
-    branches:
-      - main
+    branches: [ "main" ]
+    paths:
+      - '**.go'
+      - '**.yaml'
+      - '**.yml'
+      - '**.toml'
+      - '**.json'
+      - 'go.mod'
+      - 'go.sum'
   pull_request:
-    branches:
-      - main
+    # The branches below must be a subset of the branches above
+    branches: [ "main" ]
+    paths:
+      - '**.go'
+      - '**.yaml'
+      - '**.yml'
+      - '**.toml'
+      - '**.json'
+      - 'go.mod'
+      - 'go.sum'
 
 jobs:
   build:
-    name: Build
-    runs-on: ubuntu-latest
+    name: Build & Test
+    strategy:
+      matrix:
+        go-version: ['stable', 'oldstable']
+        platform: ['ubuntu-latest']
+    runs-on: ${{ matrix.platform }}
+    permissions:
+      # required for security related workflows
+      security-events: write
+      # only required for workflows in private repositories
+      actions: read
+      contents: read
     steps:
-      - name: Set up Go 1.x
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.19
-        id: go
-
       - name: Checkout code
         uses: actions/checkout@v3
 
-      - name: Get dependencies
-        run: |
-          go get -v -t -d ./...
-          if [ -f Gopkg.toml ]; then
-              curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
-              dep ensure
-          fi
-      - name: Test
-        run: go test ./...
-      - name: Coverage
-        run: |
-          go get github.com/axw/gocov/gocov
-          go get github.com/AlekSi/gocov-xml
-          go install github.com/axw/gocov/gocov
-          go install github.com/AlekSi/gocov-xml
-      - run: |
-          go test -v -coverprofile cover.out ./...
-          gocov convert cover.out | gocov-xml > coverage.xml
-      - uses: codecov/codecov-action@v3
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: ${{ matrix.go-version }}
+
+      - name: Vet
+        run: go vet ./...
+
+      - name: Install govulncheck
+        run: go install golang.org/x/vuln/cmd/govulncheck@latest
+
+      - name: Run govulncheck
+        run: govulncheck ./...
+
+      - name: Run Gosec Security Scanner
+        uses: securego/gosec@master
+        with:
+          # we let the report trigger content trigger a failure using the GitHub Security features.
+          args: '-no-fail -fmt sarif -out results.sarif ./...'
+      - name: Upload SARIF file
+        uses: github/codeql-action/upload-sarif@v2
+        with:
+          # Path to SARIF file relative to the root of the repository
+          sarif_file: results.sarif
+
+
+      - name: Test & Code Coverage
+        # https://go.dev/blog/cover
+        # -covermode=set (if a statement was run = default)
+        # -covermode=count (how many times a statement was run)
+        # -covermode=atomic (how many times a statement was run, even in parallel)
+        run: go test -v -coverprofile=coverage.out ./...
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./coverage.xml
-          flags: unittests
+          files: ./coverage.out
           fail_ci_if_error: false
           verbose: true
+

.gitignore

@@ -1,3 +1,5 @@
 test-operation.yaml
 .idea/
-*.iml
+*.iml
+__debug_bin*
+coverage.out

Makefile

@@ -0,0 +1,12 @@
+
+build:
+	go build ./...
+
+test:
+	go test -v -timeout 30m -count=1 ./...
+
+race:
+	go test -v -timeout 30m -count=1 -race ./...
+
+coverage:
+	go test -v -timeout 30m -count=1 -covermode=atomic -coverprofile=coverage.out ./...

datamodel/document_config_test.go

@@ -4,17 +4,20 @@
 package datamodel
 
 import (
-	"github.com/stretchr/testify/assert"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 func TestNewClosedDocumentConfiguration(t *testing.T) {
+	t.Parallel()
 	cfg := NewClosedDocumentConfiguration()
 	assert.False(t, cfg.AllowRemoteReferences)
 	assert.False(t, cfg.AllowFileReferences)
 }
 
 func TestNewOpenDocumentConfiguration(t *testing.T) {
+	t.Parallel()
 	cfg := NewOpenDocumentConfiguration()
 	assert.True(t, cfg.AllowRemoteReferences)
 	assert.True(t, cfg.AllowFileReferences)

datamodel/high/base/contact_test.go

@@ -5,15 +5,16 @@ package base
 
 import (
 	"fmt"
+	"testing"
+
 	lowmodel "github.com/pb33f/libopenapi/datamodel/low"
 	lowbase "github.com/pb33f/libopenapi/datamodel/low/base"
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v3"
-	"testing"
 )
 
 func TestNewContact(t *testing.T) {
-
+	t.Parallel()
 	var cNode yaml.Node
 
 	yml := `name: pizza
@@ -58,7 +59,7 @@ email: [email protected]`
 }
 
 func TestContact_MarshalYAML(t *testing.T) {
-
+	t.Parallel()
 	yml := `name: Buckaroo
 url: https://pb33f.io
 email: [email protected]

datamodel/high/base/discriminator_test.go

@@ -5,16 +5,17 @@ package base
 
 import (
 	"fmt"
+	"strings"
+	"testing"
+
 	lowmodel "github.com/pb33f/libopenapi/datamodel/low"
 	lowbase "github.com/pb33f/libopenapi/datamodel/low/base"
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v3"
-	"strings"
-	"testing"
 )
 
 func TestNewDiscriminator(t *testing.T) {
-
+	t.Parallel()
 	var cNode yaml.Node
 
 	yml := `propertyName: coffee

datamodel/high/base/dynamic_value_test.go

@@ -4,58 +4,67 @@
 package base
 
 import (
+	"strings"
+	"testing"
+
 	"github.com/pb33f/libopenapi/datamodel/low"
 	lowbase "github.com/pb33f/libopenapi/datamodel/low/base"
 	"github.com/pb33f/libopenapi/index"
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v3"
-	"strings"
-	"testing"
 )
 
 func TestDynamicValue_Render_A(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, int]{N: 0, A: "hello"}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "hello", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_B(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, int]{N: 1, B: 12345}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "12345", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Bool(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, bool]{N: 1, B: true}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "true", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Int64(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, int64]{N: 1, B: 12345567810}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "12345567810", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Int32(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, int32]{N: 1, B: 1234567891}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "1234567891", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Float32(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, float32]{N: 1, B: 23456.123}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "23456.123", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Float64(t *testing.T) {
+	t.Parallel()
 	dv := &DynamicValue[string, float64]{N: 1, B: 23456.1233456778}
 	dvb, _ := dv.Render()
 	assert.Equal(t, "23456.1233456778", strings.TrimSpace(string(dvb)))
 }
 
 func TestDynamicValue_Render_Ptr(t *testing.T) {
+	t.Parallel()
 
 	type cake struct {
 		Cake string
@@ -67,7 +76,7 @@ func TestDynamicValue_Render_Ptr(t *testing.T) {
 }
 
 func TestDynamicValue_Render_PtrRenderable(t *testing.T) {
-
+	t.Parallel()
 	tag := &Tag{
 		Name: "cake",
 	}
@@ -78,7 +87,7 @@ func TestDynamicValue_Render_PtrRenderable(t *testing.T) {
 }
 
 func TestDynamicValue_RenderInline(t *testing.T) {
-
+	t.Parallel()
 	tag := &Tag{
 		Name: "cake",
 	}
@@ -89,7 +98,7 @@ func TestDynamicValue_RenderInline(t *testing.T) {
 }
 
 func TestDynamicValue_MarshalYAMLInline(t *testing.T) {
-
+	t.Parallel()
 	const ymlComponents = `components:
     schemas:
      rice:
@@ -133,7 +142,7 @@ func TestDynamicValue_MarshalYAMLInline(t *testing.T) {
 }
 
 func TestDynamicValue_MarshalYAMLInline_Error(t *testing.T) {
-
+	t.Parallel()
 	const ymlComponents = `components:
     schemas:
      rice:

datamodel/high/base/example_test.go

@@ -5,16 +5,17 @@ package base
 
 import (
 	"fmt"
+	"strings"
+	"testing"
+
 	lowmodel "github.com/pb33f/libopenapi/datamodel/low"
 	lowbase "github.com/pb33f/libopenapi/datamodel/low/base"
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v3"
-	"strings"
-	"testing"
 )
 
 func TestNewExample(t *testing.T) {
-
+	t.Parallel()
 	var cNode yaml.Node
 
 	yml := `summary: an example
@@ -49,6 +50,7 @@ x-hack: code`
 }
 
 func TestExtractExamples(t *testing.T) {
+	t.Parallel()
 	var cNode yaml.Node
 
 	yml := `summary: herbs`

datamodel/high/base/external_doc_test.go

@@ -5,16 +5,17 @@ package base
 
 import (
 	"fmt"
+	"strings"
+	"testing"
+
 	lowmodel "github.com/pb33f/libopenapi/datamodel/low"
 	lowbase "github.com/pb33f/libopenapi/datamodel/low/base"
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v3"
-	"strings"
-	"testing"
 )
 
 func TestNewExternalDoc(t *testing.T) {
-
+	t.Parallel()
 	var cNode yaml.Node
 
 	yml := `description: hack code