v0.22.0 #417
Merged
v0.22.0 #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the feature folks have been waiting for.
Testing underway.
added more coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 99.61% 99.62% +0.01%
==========================================
Files 165 168 +3
Lines 22024 22652 +628
==========================================
+ Hits 21940 22568 +628
Misses 79 79
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a composed bundling mode for the bundler module to lift external file references into the document’s components section, addressing issues #294 and #397. Key changes include:
- Adding a new composed mode via the BundleDocumentComposed function.
- Updating several YAML test specifications and examples to support the new mode.
- Refactoring collision handling and reference resolution logic in the bundler Go files to integrate the new behavior.
Reviewed Changes
Copilot reviewed 158 out of 158 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bundler/test/specs/*.yaml | New and updated YAML specs for paging, examples, errors, and callbacks to validate behavior. |
| bundler/detect_type.go | Utility functions for detecting OpenAPI component types. |
| bundler/composer_functions.go & _test.go | Functions and tests for collision handling and reference processing in composition mode. |
| bundler/bundler_composer.go | Recursive index handling and composition logic for lifting external references. |
| bundler/bundler.go | Updated bundling logic to integrate composed mode and inline reference handling. |
correcting mistake found by AI. Co-authored-by: Copilot <[email protected]>
trying to kick another review.
completes the API
checking bundling works with pre-existing nested tests.
this allows for tracking of a root index when performing deeply nested reference end seeking using `seefRefEnd` in the utilities Resolves #402
Anything it does not know what to do with, it will inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new bundling mode to the
bundlermodule. A composed mode. This new mode resolves the following issues:Two new methods:
BundleBytesComposedBundleDocumentComposedcomponents.schemaswhen bundling openapi spec from multiple files? #294