fix: notify WindowHistoryAdapter when the page's URL is updated #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am1rb
force-pushed
the
fix-window-adapter
branch
from
b55ae6d to
0987512
Compare
am1rb
force-pushed
the
fix-window-adapter
branch
from
0987512 to
a1d9c6a
Compare
|
LGTM. We have this in production for a year now and it is working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue rained here: #283
WindowHistoryAdapteris broken because when a component updates a query param in the URL, the lib does not notify the query params consumer to read the new value. As a result, the URL is changed, but the internal react state holds the stale value.Also, the adapter needs to consider URL changes when someone clicks on the browser's Back and Forward buttons.
PS: My solution was also broken, and finally I ended up with the same idea as @websaid shared in #283 (comment)
This is a PR to add his solution to the repo.