Ranged Integers

[IBims1NicerTobi]

Close #28

[VonTum]

I wonder, it's not something that should concern us too badly, but maybe the boolean comparison ops should unify(left, right). Maybe, maybe not.

[VonTum]

You should add the field names. Actually, there is a function that does this already: pretty_print_concrete_instance

[IBims1NicerTobi]

Where do I get the &LinkInfo from? Should it be added to the display proxy?

[IBims1NicerTobi]

?

[VonTum]

&self.linker_types[global_ref.id].link_info

[IBims1NicerTobi]

Ok I have implemented that now but is there a reason pretty_print_concrete_instance does not return a impl Display but a String? Thats the exact issue display proxys where meant to solve.

[VonTum]

I guess where I used it, it's for setting the name field of link_info, which is a String. But having it return impl Display would be more general.

[VonTum]

Could be combined with ConcreteType::new_int_type

[IBims1NicerTobi]

How exactly? Would I call TypeSubstitutor::new_int_type and unify the unknown from the template args with the expected size?

[VonTum]

I meant that new_int_type could itself use new_int. But maybe combining them reduces usability. Perhaps a rename of new_int_type to new_unknown_int would be opportune

[IBims1NicerTobi]

Add test cases

[IBims1NicerTobi]

Add types to in code values / constants

[IBims1NicerTobi]

Cast module

[IBims1NicerTobi]

Fix this:

Error: Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
    ╭─[/home/tobias/.sus/0.2.0-devel/std/util.sus:91:11]
    │
 91 │        value = value + 1
    │                ────┬────
    │                    ╰────── Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
────╯

[VonTum]

Fix this:

Error: Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
    ╭─[/home/tobias/.sus/0.2.0-devel/std/util.sus:91:11]
    │
 91 │        value = value + 1
    │                ────┬────
    │                    ╰────── Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
────╯

Well it seems that that on its own should never typecheck. Rather either the user should specify a cast, or add a % max_val