fix: reduce resolveRailwayBin execSync timeout to prevent flaky test - #46
Open
pcapriolo wants to merge 1 commit into
Open
fix: reduce resolveRailwayBin execSync timeout to prevent flaky test#46pcapriolo wants to merge 1 commit into
pcapriolo wants to merge 1 commit into
Conversation
The 3000ms exec timeout per candidate could exceed vitest's 5000ms test timeout when multiple candidates were probed on a loaded system. Binary existence checks are either instant (ENOENT) or sub-100ms; 500ms is more than sufficient. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
resolveRailwayBin()inscripts/review-cron.tsprobes up to 4 binary candidates usingexecSyncwith a 3000ms timeout each. On a loaded system, if one candidate took ~1.5–3s to fail, the vitest test for this function would exceed its default 5000ms test timeout, causing a flaky failure.Binary existence checks are either:
500ms is more than sufficient, and eliminates the flakiness.
Tests
Verification
npm run test:run✅ 342/342 passingnpx tsc --noEmit✅ cleanFiles changed
scripts/review-cron.ts—timeout: 3000→timeout: 500