Default filebeat_version fact to nil if filebeat is not installed #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the default for *_version facts is
nil
, if the software is not available ( eg. https://github.com/voxpupuli/puppet-php/blob/master/lib/facter/phpversion.rb). The current implementation, settingfilebeat_version
tofalse
breaks spec tests for modules that include the filebeat class (a profiles module for example). This is caused by the explicitfalse
value for the fact, as the normal fact resolution is not performed during a spec test.Functionally,
false
behaves the same as thenil
value, so nothing really changes by moving the value tonil
if the software is not installed.